-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(framework): hide week numbers if firstDayOfweek is sunday #315
base: master
Are you sure you want to change the base?
Conversation
Having iso Week numbers do not make sense if the weeks themselves are not iso (not starting on monday) closes: DEV-12024
✅ Deploy Preview for luminous-medovik-367cf4 canceled.
|
This needs to be considered @SebCodesTheWeb For example, if January 1st falls on a Sunday: |
@KateKPV So are you saying we should hide week numbers all together? |
@magnusohlin no not at all, I think we should support both week starts on Sunday and Monday. The original task here is that Week numbers are not displaying correctly for users with settings that week starts on Sunday. |
@KateKPV Understood! So due to the time restrictions that we are under now, would you rather we remove the faulty weeks for the Sunday alternative or do nothing for now? |
@KateKPV @magnusohlin, this PR is my suggestion to remove faulty week numbers for now. I have a rough idea for how maybe this could be fixed in the future according to this sketch |
Having iso Week numbers do not make sense if the weeks themselves are not iso (not starting on monday)
closes: DEV-12024