Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework): hide week numbers if firstDayOfweek is sunday #315

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SebCodesTheWeb
Copy link
Contributor

Having iso Week numbers do not make sense if the weeks themselves are not iso (not starting on monday)
closes: DEV-12024

Having iso Week numbers do not make sense if the weeks
themselves are not iso (not starting on monday)
closes: DEV-12024
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for luminous-medovik-367cf4 canceled.

Name Link
🔨 Latest commit 22805ac
🔍 Latest deploy log https://app.netlify.com/sites/luminous-medovik-367cf4/deploys/66deeff26750230008618632

@KateKPV
Copy link

KateKPV commented Sep 9, 2024

This needs to be considered @SebCodesTheWeb
In Sweden, the week numbers follow the international standard ISO-8601, where the week starts on a Monday. The ISO-8601 also stipulates that the first week of the year is the week that contains the first Thursday of the year. This standardization means that if a calendar starts the week on Sunday (often seen in the US), the week numbers could differ from the ISO-8601 system used in Sweden and other parts of Europe.

For example, if January 1st falls on a Sunday:
The ISO-8601 standard will consider the Monday following January 1st as the beginning of week 1.
A Sunday-starting week calendar might mark this Sunday as the start of week 1 instead.
Therefore, the week numbers may not align across these differing systems, which is important to consider for scheduling and planning across different calendars.

@magnusohlin
Copy link
Contributor

@KateKPV So are you saying we should hide week numbers all together?

@KateKPV
Copy link

KateKPV commented Sep 10, 2024

@magnusohlin no not at all, I think we should support both week starts on Sunday and Monday. The original task here is that Week numbers are not displaying correctly for users with settings that week starts on Sunday.

@magnusohlin
Copy link
Contributor

@KateKPV Understood! So due to the time restrictions that we are under now, would you rather we remove the faulty weeks for the Sunday alternative or do nothing for now?

@SebCodesTheWeb
Copy link
Contributor Author

@KateKPV @magnusohlin, this PR is my suggestion to remove faulty week numbers for now. I have a rough idea for how maybe this could be fixed in the future according to this sketch
F1FB7350-74E9-4C02-8851-E1D67DA29C26_4_5005_c alto there could be a lot of edge cases and take some time to fix this. Problem is that it does not make sense to have ISO week numbers when the week itself is not ISO, we did not have week numbers in the previous date range picker that supported sunday as first day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants