Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build: ignore ~/.wgetrc to avoid interference #533

Merged

Conversation

devnoname120
Copy link
Contributor


name: pull request
about: submit changes to the project
title: "[pr] fix: build: ignore ~/.wgetrc to avoid interference"
labels: ''
assignees: 'louis030195'


description

Users can define personal settings for wget in ~/.wgetrc. When the wget command is run it reads this configuration file by default and add the corresponding options. The scripts/pre_build.js script fails when some user options are specified in the configuration file because they conflict with the options that this script uses. The solution is to ignore this user configuration file.

related issue: ø

type of change

  • bug fix
  • new feature
  • breaking change
  • documentation update

how to test

  1. Create a file ~/.wgetrc and just put timestamping = on inside.
  2. Run bun scripts/pre_build.js from screenpipe-app-tauri and confirm that wget errors out because -nc and --timestamp can't be combined.
  3. Move to this branch, and run bun scripts/pre_build.js again. This time around wget works properly.

checklist

  • i have read the CONTRIBUTING.md file
  • i have added the custom cursor AI prompt to my settings as mentioned in CONTRIBUTING.md and used to write this PR
  • my code follows the project's style guidelines
  • i have performed a self-review of my code
  • i have updated the documentation if necessary
  • my changes generate no new warnings
  • i have added tests that prove my fix is effective or that my feature works
  • all tests pass locally with my changes

additional notes

any other relevant information about the pr.

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
screenpipe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 0:05am

@louis030195
Copy link
Collaborator

thx @devnoname120

@louis030195 louis030195 merged commit 18fbf24 into mediar-ai:main Oct 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants