Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workaround for when a package includes a restoration #238

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dericed
Copy link
Collaborator

@dericed dericed commented May 23, 2018

No description provided.

@dericed dericed requested a review from CSchloss385 May 23, 2018 18:10
Copy link

@kieranjol kieranjol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally curious about the use case here. Would this involve two objects in the objects folder, one is the original,one is "restored"?

@dericed
Copy link
Collaborator Author

dericed commented May 23, 2018

Our immediate use case is for when we have to create multiple partial transfers to get all the content from an object, then need to create (somehow) a restoration file that combines the partial transfers into a restoration master. So here we want to accept a restoration file which will be used as an alternate to the usual objects files as the basis for any derivatives, then we also want to enable accepting multiple objects files. So the package would look like

HEY/objects/BROKEN_TAPE_TAKE1.mkv
HEY/objects/BROKEN_TAPE_TAKE2.mkv
HEY/objects/restoration/FIXED_IT.mkv
HEY/objects/access/DERIVATIVE_FROM_RESTORATION_MASTER.mp4

@kieranjol
Copy link

Lovely!

mmfunctions Outdated
@@ -6,6 +6,7 @@ OBJECTS_FIND_EXCLUSIONS=(! -name ".*")
OBJECTS_FIND_EXCLUSIONS+=(! -path "*/access/*")
OBJECTS_FIND_EXCLUSIONS+=(! -path "*/service/*")
OBJECTS_FIND_EXCLUSIONS+=(! -path "*/trimmed_materials/*")
OBJECTS_FIND_EXCLUSIONS+=(! -path "*/restoration/*")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this line is kept in, then it is unable to make access file from restoration because it does not recognize the input. Tested it without this line and then it worked. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants