Expose error callbacks, prevent always setting header #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows debugging our local app these weird errors appearing in the header. it also allows us to send the errors to rollbar instead of informing the user. Which is usefull for development, but kinda terrible for production systems. fix webpack build script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows debugging our local app, without these errors appear in the header.
it also allows us to send the errors to rollbar instead of informing the user.
Which is useful for development, but kinda bad for production systems.
I made the setHeaderMessage and resetHeaderMessage functions public so the user can emulate default behavior with the callbacks.
By default, it should keep doing whatever it was doing before.
Also fixes webpack build script on nixos.