replace innerHTML with Trusted Types friendly ways #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable usage in [Trusted Types](https://developer.mozilla.org/en-US/docs/Web/API/Trusted_Types_API) context. As Element.innerHTML is considered to be dangerous injection sink, its usage is denied when `Content-Security-Policy` enforces `require-trusted-types-for 'script'` directive. E.g. it throws something like this from `clearElement` function: ``` TypeError: Failed to set the 'innerHTML' property on 'Element': This document requires 'TrustedHTML' assignment. at D.clearElement (xyz.js:733:62) at D.start (xyz.js:710:176) ``` [textContent](https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent#differences_from_innerhtml) in MDN. [replaceChildren](https://developer.mozilla.org/en-US/docs/Web/API/Element/replaceChildren) has [~91% coverage](https://caniuse.com/mdn-api_element_replacechildren)
Snurppa
force-pushed
the
feature/unsafe-innerhtml
branch
from
a22dd3a to
c332881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable usage in Trusted Types context.
As Element.innerHTML is considered to be dangerous injection sink, its usage is denied when
Content-Security-Policyenforcesrequire-trusted-types-for 'script'directive.E.g. it throws something like this from
clearElementfunction:textContent in MDN.
replaceChildren has ~91% coverage
Off-topic FYI, some info about TT status with TypeScript: https://github.com/google/tsec#writing-trusted-type-compatible-code