Messages Internationalization (#132) #755
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi colleagues!
I suggest the following solution:
"scanner.scanningStatus"
resembling i18next library.setTranslations
function exported from the package.I guess the main pros of this approach is that it's not needed to make translations to many languages and then support them all. Those who really need it may set their own translations as they like.
If the solution is fine, I'll write unit tests and other stuff I might've missed.