Version 2.1.5 #371
Merged
Version 2.1.5 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Changelog
- Changed behavior from throwing error in case `qrbox.width` or `qrbox` is larger
than the width of the root element. In such cases the dimension will automatically
be truncated to the size of root element and will throw a warning based on verbosity
settings. This should address [issue#357](#357)
Calling `Html5QrcodeScanner#clear()` will also clear the UI rendered due to image based scan. This should address [issue#193](#193)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
qrbox.widthorqrboxis largerthan the width of the root element. In such cases the dimension will automatically
be truncated to the size of root element and will throw a warning based on verbosity
settings. This should address issue#357
qrboxis not set in config for eitherHtml5QrcodeScannerorHtml5Qrcodethe scanning box will default to the size of video stream. From UI perspective
there will be no shaded QR scanning box visible to user. This should resolve
Issue#343
Html5QrcodeScanner#clear()will also clear the UI rendered due to image based scan. This should address issue#193Resolves #357, Resolves #343, Resolves #193