Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building for different kind of loaders #325

Merged
merged 5 commits into from
Oct 17, 2021
Merged

Add support for building for different kind of loaders #325

merged 5 commits into from
Oct 17, 2021

Conversation

mebjas
Copy link
Owner

@mebjas mebjas commented Oct 17, 2021

Goals of this PR

  • Make it easy to include the library using npm
  • Make it easy to include the project with React based projects
  • Current UMD based approach shouldn't break --> should be available via unpkg as global variables.
  • Fix loadash issues

TODOs:

  • Fix version numbers.
  • Verify that library continues to works with UMD / unpkg
  • ~Fix support for former camera access APIs. ~

@mebjas mebjas linked an issue Oct 17, 2021 that may be closed by this pull request
package.json Outdated
"name": "html5-qrcode",
"version": "2.0.13",
"name": "@scanapp/html5-qrcode",
"version": "0.0.8",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix these.

src/html5-qrcode.ts Show resolved Hide resolved
webpack.config.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant