Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5px gap on bottom 90-degree brackets of qrbox #307

Closed
wants to merge 1 commit into from

Conversation

caseydwyer
Copy link

The pair of 90-degree brackets on the bottom of qrbox are nudged 5px too far down. This should (I'm like 90% sure) fix that, by pulling those two brackets (four individual pieces) back upward by 5px. Definitely check my work, but based on the other values for each object, I think this should fix it.

Below is a screenshot/example of what this aims to fix. Let me know if you have any questions, here!

image

@mebjas
Copy link
Owner

mebjas commented Oct 22, 2021

I am not able to reproduce this issue - what was the configurations you used?

@dylancom
Copy link
Contributor

dylancom commented Nov 1, 2021

Just tested the code in the PR and can confirm that it fixes the issue.

@caseydwyer
Copy link
Author

caseydwyer commented Nov 1, 2021

Sorry for the delay, October was absolutely bonkers at work. Here's the config we have atm:

QR.start(
  { facingMode: "environment" }, 
  { fps: 10, aspectRatio: 1, qrbox: { width: 200, height: 200 } },
  QrScannedCallback
);

Possibly also relevant; we're using Tailwind & Livewire on this project. We're targeting the #qr-reader element:

<div class="absolute inset-0 w-full p-4" wire:ignore>
  <div id="qr-reader" width="100%"></div>
</div>

@mebjas
Copy link
Owner

mebjas commented Nov 22, 2022

Can anyone confirm if this issue still exists?

@mebjas
Copy link
Owner

mebjas commented Nov 26, 2022

Closing this for now, please resend if the issue still exists or file an issue.

@mebjas mebjas closed this Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants