Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont rely on '\n' in echo statements #183

Merged
merged 1 commit into from
May 3, 2021
Merged

Dont rely on '\n' in echo statements #183

merged 1 commit into from
May 3, 2021

Conversation

jdtimmerman
Copy link
Contributor

As mentioned in #169, some are having some issues with the transpiling. Appearantly there are different implementations of echo that may behave differently. According to the (not really) official documentation, printf may be a more reliable alternative.

@mebjas
Copy link
Owner

mebjas commented Apr 26, 2021

Thanks for the PR, added a single comment.

Thanks!

@jdtimmerman
Copy link
Contributor Author

Ok, how about this. Instead of mixing printf's and echo's, I used multiple echo's. This gets rid of the not-universally-supported \n's but still keeps a consistent use of applications.
I've also changed how ZXing is added for consistency and with a little documentation comment

@jdtimmerman jdtimmerman changed the title Use printf instead of echo to print newlines Dont rely on '\n' in echo statements Apr 30, 2021
@mebjas
Copy link
Owner

mebjas commented May 3, 2021

Looks good to me, thanks, merginig!

@mebjas mebjas merged commit ba7b77b into mebjas:master May 3, 2021
@jdtimmerman jdtimmerman deleted the transpilingConcatenation branch May 6, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants