Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Improvements to file based scanning #612

Open
3 of 5 tasks
mebjas opened this issue Nov 17, 2022 · 2 comments
Open
3 of 5 tasks

[Feature Request] Improvements to file based scanning #612

mebjas opened this issue Nov 17, 2022 · 2 comments

Comments

@mebjas
Copy link
Owner

mebjas commented Nov 17, 2022

[1] Set canvas size to min(SOME_FIXED_MIN, input image size)

Priority: P1, effort estimate: Low

File based scanning doesn’t have constraints of real time scanning. Ok to prefer accuracy of scan as compared to latency.

  • Implement this.

[2] Configure tryHarder param in zxing-js

Priority: P1, effort estimate: Low

tryHarder param tells the library to try fallbacks like rotating images.

  • Implement this.
  • (p2) Add support for inversion of the image as if try harder or other option is enabled.

[3] Add padding to internal canvas

The library expects some padding or empty space after the code ends to ensure the code is accurately decoded. If the input image has no padding between the code and image boundary this may fail.

  • Double check that the zxing-js is not adding some padding of it’s own.
  • Add padding in case of file based scan (greater than the quiet area definition in the library)
@mebjas
Copy link
Owner Author

mebjas commented Nov 30, 2022

Implementation coming in v2.3.4 but it doesn't seem to address all issues.

Some of the issues around inability to scan a few codes still observed and need fixing.

@mebjas mebjas mentioned this issue Nov 30, 2022
@mebjas
Copy link
Owner Author

mebjas commented Nov 30, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant