Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR issues still on render with new dnd engine #791

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

1benw
Copy link
Contributor

@1benw 1benw commented Jan 12, 2025

This is in relation to Issue #778 and PR #790

Whilst #790 solved the issue for renderDropZone in the puck editor. The same issue was still in the RSC render function.

This seems to fix that, I've tested on both a RSC implementation and the puck demo app.

Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 5:52pm
puck-docs ✅ Ready (Inspect) Visit Preview Jan 12, 2025 5:52pm

Copy link

vercel bot commented Jan 12, 2025

@1benw is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

@chrisvxd chrisvxd merged commit 99e9ecb into measuredco:main Jan 12, 2025
4 checks passed
@1benw 1benw deleted the ssr-render-dropzone-not-a-function branch January 12, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants