Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react-router v7 example #752

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add react-router v7 example #752

wants to merge 7 commits into from
+899 −44

Conversation

matthewlynch
Copy link
Collaborator

@matthewlynch matthewlynch commented Dec 22, 2024 •
edited
Loading

This PR adds a react-router recipe for Puck.

Note: I had to bump the node version to 22 because some of the RR7 deps required a minimum version of 20 and that caused issues with some of the next js apps.

@vercel Vercel
Copy link

vercel bot commented Dec 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ❌ Failed (Inspect) Jan 3, 2025 10:50pm
puck-docs ❌ Failed (Inspect) Jan 3, 2025 10:50pm

@matthewlynch matthewlynch mentioned this pull request Dec 22, 2024
Open
@matthewlynch
Copy link
Collaborator Author

@chrisvxd deps are failing to install because we need to bump the minimum engine version for node:

error @react-router/[email protected]: The engine "node" is incompatible with this module. Expected version ">=20.0.0". Got "18.20.5"

chrisvxd
chrisvxd requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks @matthewlynch! Left some comments 🙃

.github/workflows/ci.yml Outdated Show resolved Hide resolved
recipes/react-router/app/routes/puck-splat.tsx Outdated Show resolved Hide resolved
recipes/react-router/app/routes/puck-splat.tsx Show resolved Hide resolved
recipes/react-router/app/root.tsx Outdated Show resolved Hide resolved
recipes/react-router/app/puck.config.tsx Outdated Show resolved Hide resolved
recipes/react-router/app/lib/resolve-puck-path.server.ts Outdated Show resolved Hide resolved
recipes/react-router/tailwind.config.ts Outdated Show resolved Hide resolved
recipes/react-router/package.json Outdated Show resolved Hide resolved
recipes/react-router/README.md Outdated Show resolved Hide resolved
recipes/react-router/README.md Show resolved Hide resolved
chrisvxd
chrisvxd requested changes Jan 3, 2025
View reviewed changes
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, couple more comments.

Re Node v22, we just need to make sure we're not changing the Puck minimum node version just to support an RR7 template

recipes/react-router/app/entry.server.tsx Outdated Show resolved Hide resolved
recipes/react-router/app/root.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvxd chrisvxd chrisvxd requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewlynch @chrisvxd