Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: booleans type in select/radio fields #748

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

thopedam
Copy link
Contributor

safeJsonParse(false) returns false so const jsonValue will be "false" and cannot be found in flatOptions.

We need to check for undefined and not for false.

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 4:30pm
puck-docs ✅ Ready (Inspect) Visit Preview Dec 18, 2024 4:30pm

Copy link

vercel bot commented Dec 18, 2024

@thopedam is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh, good catch! Unfortunately this will miss 0.17, which just got released.

@thopedam
Copy link
Contributor Author

Just updated to 0.17.0 and was confused about my booleans not working anymore.. 😀

@chrisvxd chrisvxd merged commit 3406b01 into measuredco:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants