Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow react elements in external field mapRow #682

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

camhammel
Copy link
Contributor

@camhammel camhammel commented Nov 6, 2024

Description

Screenshots

image

       mapRow: (item) => ({
        img: (
          <img src="https://placehold.co/600x400" height="40" width="60" />
        ),
        title: item.title,
        description: item.description,
      }),

Copy link

vercel bot commented Nov 6, 2024

@camhammel is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 2:49pm
puck-docs ✅ Ready (Inspect) Visit Preview Nov 7, 2024 2:49pm

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @camhammel - this looks good. I try and include examples in the demo, which helps to validate things work and build correctly.

Could you add a superficial example here? Just wrap the description in a <span> or something.

@camhammel
Copy link
Contributor Author

Thanks @camhammel - this looks good. I try and include examples in the demo, which helps to validate things work and build correctly.

Could you add a superficial example here? Just wrap the description in a <span> or something.

@chrisvxd good call, done!

@camhammel camhammel requested a review from chrisvxd November 7, 2024 14:31
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Going to hold off merging until we get closer to our next v0.17 feature release.

Let me know if you need this soon and I can publish a canary.

@chrisvxd chrisvxd merged commit 8ea38c3 into measuredco:main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow mapRow to return more than just string and number types
2 participants