refactor: zone setup #677
Merged
refactor: zone setup #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
chrisvxd
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a crash that occurs when using the Puck editor with Redux in a component that renders a
DropZone. Currently, attempting this results in an error:[TypeError: can't define property x, objY is not extensible].Root Cause
The issue stems from a mutation in Puck's
setupZoneutility, which modifiesdata.zonesdirectly. This can lead to unexpected behavior and crashes in environments where immutability is expected, such as with Redux.Solution
This PR introduces a simple refactor of
prepareZoneto prevent direct mutation ofdata.zones, ensuring compatibility with Redux and immutability principles.