Skip to content

Added type for button #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

antonmalyavkin
Copy link
Contributor

@antonmalyavkin antonmalyavkin commented Aug 29, 2024

If use PUCK inside <Form />, <button/> without type="button" submits the form

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 7:39pm
puck-docs ✅ Ready (Inspect) Visit Preview Sep 3, 2024 7:39pm

Copy link

vercel bot commented Aug 29, 2024

Someone is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting is failing. Please ensure you're running prettier. You can do this using yarn format.

@chrisvxd chrisvxd merged commit f761e5f into measuredco:main Sep 3, 2024
4 checks passed
@chrisvxd
Copy link
Member

chrisvxd commented Sep 3, 2024

Thanks @antonmalyavkin - should be in next release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants