Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix support for boolean values with select field. #419

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

estephan
Copy link
Contributor

@estephan estephan commented Apr 4, 2024

When using a boolean value with the select field, the value always evaluates to true (a similar implementation works as expected with the radio field).

puck-select-boolean

https://codesandbox.io/p/sandbox/sleepy-fast-x7cdwn

Working Radio field code.

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 9:18am
puck-docs ✅ Ready (Inspect) Visit Preview Apr 4, 2024 9:18am

Copy link

vercel bot commented Apr 4, 2024

@estephan is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the contribution.

@chrisvxd chrisvxd merged commit c4a66ad into measuredco:main Apr 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants