fix: prevent infinite loop when using plugins with some frameworks

Testing remix with the emotion-cache-plugin was resulting in an infinite loop due to the way that plugins and overrides were defaulted.
measuredco · Aug 31, 2024 · 3870871 · 3870871
1 parent 041c4a8
commit 3870871
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/packages/core/components/Puck/index.tsx b/packages/core/components/Puck/index.tsx
@@ -69,8 +69,8 @@ export function Puck<UserConfig extends Config = Config>({
   onPublish,
   onAction,
   permissions = {},
-  plugins = [],
-  overrides = {},
+  plugins,
+  overrides,
   renderHeader,
   renderHeaderActions,
   headerTitle,
@@ -393,7 +393,7 @@ export function Puck<UserConfig extends Config = Config>({
           config,
           componentState,
           resolveData,
-          plugins,
+          plugins: plugins || [],
           overrides: loadedOverrides,
           history,
           viewports,

diff --git a/packages/core/lib/load-overrides.ts b/packages/core/lib/load-overrides.ts
@@ -5,12 +5,12 @@ export const loadOverrides = ({
   overrides,
   plugins,
 }: {
-  overrides: Partial<Overrides>;
-  plugins: Plugin[];
+  overrides?: Partial<Overrides>;
+  plugins?: Plugin[];
 }) => {
   const collected = { ...overrides };
 
-  plugins.forEach((plugin) => {
+  plugins?.forEach((plugin) => {
     Object.keys(plugin.overrides).forEach((overridesType) => {
       if (overridesType === "fieldTypes") {
         const fieldTypes = plugin.overrides.fieldTypes!;

diff --git a/packages/core/lib/use-loaded-overrides.ts b/packages/core/lib/use-loaded-overrides.ts
@@ -7,8 +7,8 @@ export const useLoadedOverrides = ({
   overrides,
   plugins,
 }: {
-  overrides: Partial<Overrides>;
-  plugins: Plugin[];
+  overrides?: Partial<Overrides>;
+  plugins?: Plugin[];
 }) => {
   return useMemo(() => {
     return loadOverrides({ overrides, plugins });