feat: allow react elements in external field mapRow

measuredco · Nov 14, 2024 · 2f781de · 2f781de
1 parent 5ba9399
commit 2f781de
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/core/components/ExternalInput/index.tsx b/packages/core/components/ExternalInput/index.tsx
@@ -1,4 +1,10 @@
-import { useMemo, useEffect, useState, useCallback } from "react";
+import {
+  useMemo,
+  useEffect,
+  useState,
+  useCallback,
+  isValidElement,
+} from "react";
 import styles from "./styles.module.css";
 import getClassNameFactory from "../../lib/get-class-name-factory";
 import { ExternalField } from "../../types";
@@ -54,7 +60,11 @@ export const ExternalInput = ({
 
     for (const item of mappedData) {
       for (const key of Object.keys(item)) {
-        if (typeof item[key] === "string" || typeof item[key] === "number") {
+        if (
+          typeof item[key] === "string" ||
+          typeof item[key] === "number" ||
+          isValidElement(item[key])
+        ) {
           validKeys.add(key);
         }
       }

diff --git a/packages/core/types/Fields.ts b/packages/core/types/Fields.ts
@@ -91,7 +91,7 @@ export type ExternalField<
     filters: Record<string, any>;
   }) => Promise<any[] | null>;
   mapProp?: (value: any) => Props;
-  mapRow?: (value: any) => Record<string, string | number>;
+  mapRow?: (value: any) => Record<string, string | number | ReactElement>;
   getItemSummary?: (item: Props, index?: number) => string;
   showSearch?: boolean;
   initialQuery?: string;