Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Simple Test Enhancement #1658

Closed
jrodenbostel opened this issue Nov 30, 2016 · 0 comments · Fixed by GulajavaMinistudio/mean#5
Closed

Simple Test Enhancement #1658

jrodenbostel opened this issue Nov 30, 2016 · 0 comments · Fixed by GulajavaMinistudio/mean#5

Comments

@jrodenbostel
Copy link
Contributor

I'd like to propose a simple enhancement to the test cases for the example Article module. The enhancement would cover cases where test cases fail without sharing useable debugging data when Articles can't be saved (which can happen for a variety of reasons).

The change would happen on line 309, and contain a simple conditional checking for an error and printing it out if one exists. I'm submitting a pull request shortly with this enhancement. Other reference for this enhancement exists here: meanjs/generator-meanjs#257

jrodenbostel pushed a commit to jrodenbostel/mean that referenced this issue Nov 30, 2016
Simple test enhancement proposed by @jrodenbostel.  Eases troubleshooting when Article save fails during test execution.

Further reference here: meanjs/generator-meanjs#257

Fixes meanjs#1658
mleanos pushed a commit that referenced this issue Jun 13, 2017
* feat(articles): Simple test enhancement

Simple test enhancement proposed by @jrodenbostel.  Eases troubleshooting when Article save fails during test execution.

Further reference here: meanjs/generator-meanjs#257

Fixes #1658

* updated per @simison's request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant