Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crop/qt5] Drag mode #213

Closed
wants to merge 2 commits into from
Closed

[crop/qt5] Drag mode #213

wants to merge 2 commits into from

Conversation

szlldm
Copy link
Contributor

@szlldm szlldm commented Jan 19, 2021

This feature branch is the continuation of 73b5bdd (pending Pull Request #212)

Actually editing video, i was still unsatisfied with the crop filter, because repositioning the selection was hard.
Therefore added a drag mode, by replacing "Keep aspect" chechbox with a comboBox, which has:
-Free resize (this is the original mode)
-Free drag
-Keep aspect ratio

However there is a bug i cant figure out (i suspect, it is in the underlying rubber mechanism):
start dragging, the drag point (top-left corner) can not be dragged beyond the pivot point, determined by the bottom-right corner when drag started. The visible rubber band resizes (moves) as it suppose to do, but it acts as if it were a secondary but invisible rubber band, that dont.
Releasing the drag grip, the dragging can be continued, with the new pivot point.

@eumagga0x2a
Copy link
Collaborator

Thank you. A feature to grab the rubber rectangle at any position outside the grips and drag it around would be indeed cool. You could probably subclass ADM_rubberControl and use mouse events. If it works well, it should go into ADM_rubberControl itself.

It would be great to explore it post-release.

-r for any implementation requiring configuration, however.

@szlldm
Copy link
Contributor Author

szlldm commented Jan 20, 2021

Yes, it need more work. I already used this feature in editing, and its neat, apart from the bug.
It really acts like the rubber->resize doesnt work until the grip is released. Weird.
I will look into it, if i have free time.

@szlldm szlldm closed this Jan 23, 2021
@szlldm szlldm deleted the crop_drag branch January 23, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants