Don't use spread operator #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing @mdx-js/runtime in create-react-app v1 fails because of spread operators.
|
This pull request is automatically deployed with Now. |
|
I just realized we should figure out what node version is being run, this shouldn't be required 🤔 |
|
I was running the example in #281 using latest Node, so I was really surprised to see the same error. I’m not that familiar with CRA, all I know is that importing the runtime using v2 works. 🧐 I think it’s best to get this fix merged and released, then afterwards I can dive into what exactly happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing @mdx-js/runtime in create-react-app v1 fails because of spread operators.
I didn't dive deep enough to understand why, though.
Fixes #281.