Skip to content

Revert including ASGI root_path in url to validate #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejinotti-mdsol merged 3 commits into from
Jan 23, 2024
Merged

Revert including ASGI root_path in url to validate #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ff8ec8
Update to latest version of FastAPI for ASGI tests
pburke-mdsol Jan 22, 2024
c8543bf
Revert prepending root_path to path
pburke-mdsol Jan 23, 2024
a963175
Bump version to 1.6.3 and update changelog
pburke-mdsol Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 1.6.3
- Revert change introduced in v1.6.2 now that Starlette has been updated to
always include `root_path` in `path`.

# 1.6.2
- Fix `MAuthASGIMiddleware` signature validation when the full URL path is split
between `root_path` and `path` in the request scope.
Expand Down
3 changes: 1 addition & 2 deletions mauth_client/middlewares/asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ async def __call__(
if scope["type"] != "http" or path in self.exempt:
return await self.app(scope, receive, send)

root_path = scope["root_path"]
query_string = scope["query_string"]
url = f"{root_path}{path}?{decode(query_string)}" if query_string else f"{root_path}{path}"
url = f"{path}?{decode(query_string)}" if query_string else path
headers = {decode(k): decode(v) for k, v in scope["headers"]}

events, body = await self._get_body(receive)
Expand Down
Loading