Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a setting to preview only when a key is held #99

Closed
mdolr opened this issue Oct 9, 2020 · 0 comments
Closed

Add a setting to preview only when a key is held #99

mdolr opened this issue Oct 9, 2020 · 0 comments
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Milestone
Next release

Comments

@mdolr
Copy link
Owner

mdolr commented Oct 9, 2020 •
edited
Loading

Maybe people don’t want to preciew everything, we could add a setting to only preview things if a key is being pressed.

Users should be able to modify this key

Suggestion from reddit
@mdolr mdolr added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest Future improvements Should be treated / discussed for future versions labels Oct 9, 2020
@mdolr mdolr added this to the Next release milestone Oct 10, 2020
mdolr added a commit that referenced this issue Oct 12, 2020
@mdolr
Alternative way to implement #99
d822534 
Implements a intent timeout, so we can make sure the user wants to preview this link
@mdolr mdolr closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Future improvements Should be treated / discussed for future versions good first issue Good for newcomers hacktoberfest This repository is public and will count towards your PR count for the Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
Next release
Development

No branches or pull requests
1 participant
@mdolr