Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(macros): delete {{Interwiki}} macro #9264

Merged
merged 2 commits into from
Jul 17, 2023
Merged

chore(macros): delete {{Interwiki}} macro #9264

merged 2 commits into from
Jul 17, 2023

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Jul 9, 2023

Summary

We have removed all the macro calls in translated-content. It's time to remove this from yari :)

run the following command to verify:

rg -il "\{\{\s*Interwiki" | wc -l # got 0

image

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jul 9, 2023
@caugner caugner self-requested a review July 17, 2023 11:58
caugner
caugner approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you, and good catch regarding the other, already removed macros! 🙏

@caugner caugner merged commit 74431cf into mdn:main Jul 17, 2023
10 checks passed
@yin1999 yin1999 deleted the patch-2 branch July 17, 2023 12:24
@github-actions github-actions bot mentioned this pull request Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yin1999 @caugner