Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macros): add GlossarySidebar macro #8997

Merged
merged 4 commits into from
Jun 5, 2023
Merged

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jun 2, 2023

This PR adds a dedicated {{GlossarySidebar}} macro.

Related pull requests

Problem

We do not have a sidebar in any Glossary sub-page. This PR introduces a macro that lists all pages under glossary/*/index.md

Solution

A macro {{GlossarySidebar}} that will list all Glossary pages for discovery.

Screenshots

Before

image

After

image

How did you test this change?

locally with yarn && yarn dev

Open questions

  • Do we need tests for this?

@bsmth bsmth requested a review from caugner June 2, 2023 11:15
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jun 2, 2023
kumascript/macros/GlossarySidebar.ejs Outdated Show resolved Hide resolved
kumascript/macros/GlossarySidebar.ejs Outdated Show resolved Hide resolved
@bsmth bsmth marked this pull request as ready for review June 2, 2023 12:33
@bsmth bsmth requested a review from caugner June 2, 2023 12:39
@caugner caugner changed the title chore: Add a GlossarySidebar macro for sidebars feat(macros): add GlossarySidebar macro Jun 2, 2023
@caugner caugner requested a review from wbamberg June 2, 2023 22:33
@caugner
Copy link
Contributor

caugner commented Jun 2, 2023

@wbamberg Any concerns?

PS: Have a nice weekend!

@caugner caugner merged commit e704315 into mdn:main Jun 5, 2023
@bsmth bsmth deleted the glossary-sidebar branch June 8, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants