-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(macros/cssxref): correct URL generation for data types and functions #8766
Conversation
The unit test is complaining about |
@yarusome The unit test does not access mdn/content, but instead uses some mock pages, and the mocked yari/kumascript/tests/macros/cssxref.test.ts Lines 37 to 45 in f6e5179
Updating those urls should fix the failing test. |
@caugner Thanks for the hint. All unit tests pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Fixes #8755.
Problem
{{CSSXref}}
Generated URLs for CSS functions contain extra parentheses.:host()
andfit-content()
are not handled correctly.<overflow>
is not handled correctly.cssxref.ejs
are outdated.Solution
slug
._funtion
toslug
.How did you test this change?
Run the following code in the console: