feat(client/env): split CRUD_MODE into WRITER_MODE and DEV_MODE #8383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we place a lot of “local environment” features/setup behind the CRUD_MODE environment variable. There's some problems with that: - It enables a bunch of writer-specific features we really don't need as devs, such as index.json reloading every few seconds, and the flaws toolbar - It isn't enabled on :5042, so testing certain features (such as glean) aren't possible on that port, as they require further setup locally which isn't done when CRUD_MODE is false
github-actions
bot
added
github-actions
plus
caugner
reviewed
Mar 10, 2023
|
@LeoMcA How about prefixing this PR with |
LeoMcA
changed the title
LeoMcA
changed the title
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
caugner
requested changes
Apr 4, 2023
github-actions
bot
removed
the
merge conflicts 🚧
caugner
changed the title
caugner
approved these changes
May 30, 2023
There was a problem hiding this comment.
LGTM, although we might want to redirect from http://localhost:3000/ to http://localhost:3000/en-US/ if REACT_APP_WRITER_MODE is disabled.
caugner
reviewed
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we place a lot of “local environment” features/setup behind
the CRUD_MODE environment variable. There's some problems with that:
as devs, such as index.json reloading every few seconds, and the flaws
toolbar
aren't possible on that port, as they require further setup locally
which isn't done when CRUD_MODE is false
(MP-292)