feat: add placements #8213
Merged
feat: add placements #8213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
caugner
requested changes
Feb 14, 2023
.github/workflows/stage-build.yml
Outdated
| @@ -231,6 +234,10 @@ jobs: | |||
|
|
|||
| DEPLOYER_LAMBDA_PREFIX: stage- | |||
|
|
|||
| KEVEL_SITE_ID: ${{ secrets.DEPLOYER_STAGE_KEVEL_SITE_ID }} | |||
| KEVEL_NETWORK_ID: ${{ secrets.DEPLOYER_STAGE_KEVEL_NETWORK_ID }} | |||
| SIGN_SECRET: ${{ secrets.DEPLOYER_STAGE_SIGN_KEY }} | |||
There was a problem hiding this comment.
This sign secret not specific to Kevel?
Comment on lines
74
to
77
| ["updates", "Filter and sort updates"], | ||
| ["collections", "Collections of articles"], | ||
| ["offline", "MDN Offline"], | ||
| ["ads-free", "Ads free", "new"], |
There was a problem hiding this comment.
Feel like these should be objects 🤔
LeoMcA
reviewed
Feb 14, 2023
caugner
requested changes
Feb 14, 2023
| pong: PlacementStatus, | ||
| observer: IntersectionObserver | null = null | ||
| ) { | ||
| navigator?.sendBeacon?.( |
There was a problem hiding this comment.
We wanted to pull the check inside here:
Suggested change
| navigator?.sendBeacon?.( | |
| navigator && navigator.sendBeacon?.( |
Comment on lines
+55
to
+56
| const userAgentHeader = request.headers["user-agent"]; | ||
| const userAgent = userAgentHeader ? userAgentHeader[0].value : null; |
There was a problem hiding this comment.
We only use these in one branch.
Comment on lines
+193
to
+196
| return { | ||
| status: 405, | ||
| statusDescription: "METHOD_NOT_ALLOWED", | ||
| }; |
There was a problem hiding this comment.
I'd almost extract these into const HTTP_405_METHOD_NOT_ALLOWED for reuse.
caugner
reviewed
Feb 14, 2023
LeoMcA
reviewed
Feb 14, 2023
deployer/aws-lambda/kevel/index.js
Outdated
| } | ||
| } else { | ||
| payload = { | ||
| copy: contents?.[0]?.data?.title || "🦖", |
There was a problem hiding this comment.
Perhaps just make this optional in the type in placement.tsx, and deal with a null value there?
Comment on lines
+175
to
+195
| function getIsDocumentHidden() { | ||
| if (typeof document !== "undefined") { | ||
| return !document.hidden; | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| export function usePageVisibility() { | ||
| const [isVisible, setIsVisible] = React.useState(getIsDocumentHidden()); | ||
| const onVisibilityChange = () => setIsVisible(getIsDocumentHidden()); | ||
| useEffect(() => { | ||
| if (typeof document !== "undefined") { | ||
| const visibilityChange = "visibilitychange"; | ||
| document.addEventListener(visibilityChange, onVisibilityChange, false); | ||
| return () => { | ||
| document.removeEventListener(visibilityChange, onVisibilityChange); | ||
| }; | ||
| } | ||
| }); | ||
| return isVisible; | ||
| } |
There was a problem hiding this comment.
This whole section of code is a bit weird, how about:
Suggested change
| function getIsDocumentHidden() { | |
| if (typeof document !== "undefined") { | |
| return !document.hidden; | |
| } | |
| return false; | |
| } | |
| export function usePageVisibility() { | |
| const [isVisible, setIsVisible] = React.useState(getIsDocumentHidden()); | |
| const onVisibilityChange = () => setIsVisible(getIsDocumentHidden()); | |
| useEffect(() => { | |
| if (typeof document !== "undefined") { | |
| const visibilityChange = "visibilitychange"; | |
| document.addEventListener(visibilityChange, onVisibilityChange, false); | |
| return () => { | |
| document.removeEventListener(visibilityChange, onVisibilityChange); | |
| }; | |
| } | |
| }); | |
| return isVisible; | |
| } | |
| export function usePageVisibility() { | |
| const [isVisible, setIsVisible] = React.useState( | |
| typeof document === "undefined" | |
| ? false | |
| : document.visibilityState === "visible" | |
| ); | |
| useEffect(() => { | |
| const onVisibilityChange = () => | |
| setIsVisible(document.visibilityState === "visible"); | |
| document.addEventListener("visibilitychange", onVisibilityChange); | |
| return () => { | |
| document.removeEventListener("visibilitychange", onVisibilityChange); | |
| }; | |
| }, []); | |
| return isVisible; | |
| } | |
| } |
caugner
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.