Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ARIARole macro #8025

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Deprecate ARIARole macro #8025

merged 3 commits into from
Jan 30, 2023

Conversation

teoli2003
Copy link
Contributor

@estelle removed the last occurrences in mdn/content. We can mark it as deprecated.

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jan 24, 2023
@teoli2003
Copy link
Contributor Author

I've opened mdn/content#23859 to fix the (unrelated) test failure.

@teoli2003
Copy link
Contributor Author

We fixed the kitchensink page in mdn/content#23859, so I guess that rerunning the tests here should get them fixed (but I can't launch them again)

@nschonni
Copy link
Collaborator

The unrelated failure was fixed upstream, so it should go green if you update the branch to re-run the tests

@queengooborg
Copy link
Collaborator

Can confirm there are no more instances in English content using yarn tool macro-usage-report; only 70 remain across translated content.

@caugner caugner merged commit 92a9e8a into mdn:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants