enhance(filecheck): validate all file paths for lowercase and special characters

[OnkarRuikar]

Addresses mdn/content#20470 (comment)

Ban parentheses from content file paths.

---

The PR also fixes currently on going erroneous message: Error: files/en-us/web/http/cookies/cookie-basic-example.drawio file-type could not be extracted at all (probably not a .drawio file)
This is because the code considers .drawio as a binary file.

[caugner]

LGTM, very good initiative, thanks! 👏

Just some nits and possible improvements:

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[OnkarRuikar]

Made small fix in compression logic. Below image is getting compressed to bigger size: 😕

error: Error: ../content/files/en-us/web/api/htmlimageelement/sizes/new-york-skyline-wide.jpg is too large (443.9KB > 500.0KB), even after compressing to 512.7KB.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[fiji-flo]

@OnkarRuikar thanks a lot for this. And sorry for not getting to it in time. I left some inline comments. But to sum it up. As soon as the minor regressions are fixed this is great and ready to go.

[yin1999]

Cross reference: #10859

I wonder if we should only use characters that won't be URL encoded

[OnkarRuikar]

I wonder if we should only use characters that won't be URL encoded

I've addressed this in the code:

 // Use only ASCII characters
  const normalized = shortPath.normalize("NFD");
  if (shortPath !== normalized) {
    errors.push(
      `Error: Invalid path: ${filePath}. Use only plain ASCII characters.`
    );
  }

At the moment it logs:

error: Error: Invalid path: /home/onkar/GitHub/mdn/translated-content/files/fr/glossary/bezier_curve/bézier_2_big.gif. Use only plain ASCII characters.
       Error: Invalid path: /home/onkar/GitHub/mdn/translated-content/files/ru/learn/html/introduction_to_html/getting_started/безымянный.png. Use only plain ASCII characters.
       Error: Invalid path: /home/onkar/GitHub/mdn/translated-content/files/ja/orphaned/mozilla/add-ons/webextensions/debugging_(before_firefox_50)/index.md. File path must not include characters: '(', ')'
       FixableError: /home/onkar/GitHub/mdn/content/files/en-us/web/css/css_containment/container_queries/container-query.svg is 52.4KB and can be compressed to 38.4KB (27%)

[OnkarRuikar]

@fiji-flo there is one more issue about filecheck tool. When content of an index.md is updated and surrounding image is no longer used in the content the image becomes orphan current tool doesn't report it on index.md modifications. The tool needs to look in the parent directory of index.md for images and check them as well. Should we fix this in this PR or handle it in a new one?

[caugner]

The tool needs to look in the parent directory of index.md for images and check them as well. Should we fix this in this PR or handle it in a new one?

Sorry for the late reply, I would recommend to open a separate PR.

[OnkarRuikar]

I would recommend to open a separate PR.

can we merge this now then? 😃