Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros): remove unused Link macro #7237

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

MrBrain295
Copy link
Contributor

Summary

There are no remaining occurrences of the link macro in translated content.

Problem

It’s not needed.

Solution

Delete it.


Screenshots

N/a

Before

N/a

After

N/a


How did you test this change?

N/a

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 25, 2022
@yin1999
Copy link
Member

yin1999 commented Sep 26, 2022

The macro removal has been tracked in mdn/translated-content#7566. Confirmed by rg:

image

@MrBrain295
Copy link
Contributor Author

MrBrain295 commented Oct 4, 2022

@fiji-flo

@fiji-flo
Copy link
Contributor

https://github.com/mdn/translated-content/blob/main/files/es/web/javascript/typed_arrays/index.md still has a link marco.

Did that get added in the meanwhile? Sorry for missing this.

@yin1999
Copy link
Member

yin1999 commented Oct 19, 2022

Did that get added in the meanwhile? Sorry for missing this.

Maybe this PR: mdn/translated-content#8200

@caugner caugner marked this pull request as draft October 19, 2022 17:14
@caugner
Copy link
Contributor

caugner commented Oct 19, 2022

Converting to draft until new {{Link}} occurrences in translated-content are removed again:

% rg -i '\{\{\s*link' content translated-content                                                                                                                                                                                                                          1 ↵
content/files/en-us/mdn/writing_guidelines/page_structures/macros/deprecated_macros/index.md
14:## The \{{Link}} macro
25:The \{{Link("/en-US/docs/Web/JavaScript/Guide/Numbers_and_dates")}} page on MDN

translated-content/files/es/web/javascript/typed_arrays/index.md
55:- {{Link("/en-US/docs/Web/API/FileReader", "FileReader.prototype.readAsArrayBuffer()", "#readAsArrayBuffer()")}}
56:  - : El método `FileReader.prototype.readAsArrayBuffer()` comienza a leer el contenido del {{Link("/es/docs/Web/API/Blob", "Blob")}} o {{Link("/es/docs/Web/API/File", "File")}}.
59:- {{Link("/en-US/docs/Web/API/ImageData", "ImageData.data")}}
125:Al combinar un solo búfer con múltiples vistas de diferentes tipos, comenzando con diferentes desplazamientos en el búfer, puedes interactuar con objetos de datos que contienen múltiples tipos de datos. Esto te permite, por ejemplo, interactuar con complejas estructuras de datos {{Link("/es/docs/Web/WebGL", "WebGL")}}, archivos de datos o estructuras C que necesitas utilizar mientras usas {{Link("/en-US/docs/Mozilla/js-ctypes", "js-ctypes")}}.

@caugner caugner changed the title Delete the link macro chore(macros): remove unused Link macro Oct 19, 2022
@MrBrain295
Copy link
Contributor Author

I opened a pr to remove the last few occurrences mdn/translated-content#9373

@MrBrain295
Copy link
Contributor Author

The pr got merged so I think this one is ready.

@caugner caugner marked this pull request as ready for review October 20, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants