chore(macros/LearnSidebar): add MathML tutorial #6953
Merged
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
caugner
changed the title
|
Blocked by: mdn/content#19467 |
fred-wang
force-pushed
the
sidebar-mathml-tutorial
branch
from
2c9ba9d
to
8213dc7
Compare
fred-wang
added a commit
to fred-wang/yari
that referenced
this pull request
Sep 6, 2022
fred-wang
force-pushed
the
sidebar-mathml-tutorial
branch
from
8213dc7
to
d9c9bd8
Compare
fred-wang
force-pushed
the
sidebar-mathml-tutorial
branch
from
d9c9bd8
to
a1bc632
Compare
caugner
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MDN learn pages [1] have a sidebar to quickly access various sections (HTML, CSS, JavaScript, etc). This PR adds the corresponding ones for the MathML tutorial added in [2]. Fixes #6952.
[1] https://developer.mozilla.org/en-US/docs/Learn
[2] mdn/content#19467
Problem
MathML tutorial is not accessible from the learn sidebar, so users cannot find it from the Learn pages.
Solution
Add links for the MathML tutorial to existing sidebar.
Screenshots
Before
After
How did you test this change?
I used
yarn devand opened a few subpages of http://localhost:3000/en-US/docs/Learn ; checking the added MathML sections properly display in the sidebar and that the links are not broken, and that one can fold/unfold the "MathML first steps" subsections by clicking on it.