fix(icons): use dinocon symbol for experimental support #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
LGTM, tested locally on this article:
I will request an additional review from a peer though.
PS: I believe we have a content issue here though, because the sidebar shows experimental for cancelAnimationFrame, whereas the BCD table shows experimental for cancelIdleCallback.
caugner
changed the title
5 tasks
schalkneethling
suggested changes
Mar 15, 2022
There was a problem hiding this comment.
One change request. Other than that, this is a great change. Thanks, @danielhjacobs 🎉
|
@danielhjacobs Thank you for the change but, I see you accidentally also removed |
danielhjacobs
force-pushed
the
experimental-use-dinocon
branch
from
1926667
to
ca5c76e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5588
Problem
The old experimental icon was the dinocon, and the new asset is harder to see in certain parts of the website.
Solution
Copy-paste the dinocon to replace the svg.
Screenshots
Before
After