Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno to browser compat data table #4451

Merged
merged 9 commits into from
Aug 20, 2021
Merged

Conversation

lucacasonato
Copy link
Contributor

@lucacasonato lucacasonato commented Aug 10, 2021

This commit adds Deno BCD to the browser compat data table. The "servers"
category (Deno and Node.js) is shown if either Node.js or Deno has compat data
for a given API.

TODOs:

  • Switch to new release of @mdn/dinocons once that is release. Will
    include this PR: Add platforms/deno icon mdn-dinocons#37
  • Switch to 4.0.0 release of BCD once that is released. This will include
    data for Deno.

This commit adds Deno BCD to the browser compat data table. The
"servers" category (Deno and Node.js) is shown if either Node.js or
Deno has compat data for a given API.
@lucacasonato lucacasonato marked this pull request as draft August 10, 2021 15:01
@schalkneethling
Copy link
Contributor

In terms of the SVG, does this work @lucacasonato?

Screenshot 2021-08-10 at 19 14 54

@lucacasonato
Copy link
Contributor Author

@schalkneethling Yeah, that is what I used now. All the other logos are pure black/transparent and less detailed though (the Deno one is very slightly gray if I remember right). Maybe best would just be if I make the image fully black and white. I'll play around with it and see if I can make it look like the other icons.
image

@lucacasonato
Copy link
Contributor Author

@schalkneethling I have opened a PR to add a black icon for Deno to @mdn/dinocons: mdn/mdn-dinocons#37. Figma asset is included too.

This PR now links to my GH fork of @mdn/dinocons. This will need to be resolved before the PR can be landed.

@schalkneethling
Copy link
Contributor

@schalkneethling I have opened a PR to add a black icon for Deno to @mdn/dinocons: mdn/mdn-dinocons#37. Figma asset is included too.

This PR now links to my GH fork of @mdn/dinocons. This will need to be resolved before the PR can be landed.

Thank you, this has been merged. I will do a release either today or tomorrow.

@lucacasonato
Copy link
Contributor Author

Thanks @schalkneethling!

@schalkneethling
Copy link
Contributor

Thanks @schalkneethling!

Release incoming mdn/mdn-dinocons#40

@ddbeck
Copy link
Contributor

ddbeck commented Aug 19, 2021

BCD v4.0.0 just dropped, which is the first BCD release to contain Deno data. Looking forward to seeing this PR ship after Yari upgrades!

@lucacasonato lucacasonato marked this pull request as ready for review August 19, 2021 16:20
@lucacasonato
Copy link
Contributor Author

Todos have been resolved, PR now ready for review :-)

Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look great. Great if someone else could test and check it too.

Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ Thanks so much @lucacasonato 🦖

@schalkneethling schalkneethling merged commit 1940c17 into mdn:main Aug 20, 2021
@lucacasonato lucacasonato deleted the deno branch August 20, 2021 09:36
@caugner caugner added the browser-compat issues related to the browser compatibility data tables (BCD) label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-compat issues related to the browser compatibility data tables (BCD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants