a flag to not build index.html #4258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbe
suggested changes
Jul 21, 2021
content/translations.js
Outdated
| @@ -15,6 +15,9 @@ function gatherTranslations() { | |||
| for (const { | |||
| metadata: { slug, locale, title }, | |||
| } of iter) { | |||
| if (!slug) { | |||
build/cli.js
Outdated
| path.join(outPath, "index.html"), | ||
| renderHTML(document.url, { doc: builtDocument }) | ||
| ); | ||
| if (noHTML) { |
There was a problem hiding this comment.
Suggested change
| if (noHTML) { | |
| if (!noHTML) { |
no?
There was a problem hiding this comment.
No idea how that disappeared 😱 But that happened when I renamed the parameter. This PR is even more broken.
|
Another interesting one to consider is all the other things that builds. Or, what about |
option to not build index.html files
fiji-flo
force-pushed
the
json-only-build
branch
from
68af556
to
efc139a
Compare
|
Sorry for that mess, good catch. Beyond my mess, for some reason naming the option |
|
We might wanna add more granularity to it. For now this builds everything needed for client side rendering. |
peterbe
reviewed
Jul 21, 2021
peterbe
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when using yari as SPA