Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmbedLiveSample fails if the ID gets changed from the text #2490

Merged
merged 1 commit into from
Jan 13, 2021
Merged

EmbedLiveSample fails if the ID gets changed from the text #2490

merged 1 commit into from
Jan 13, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Jan 12, 2021

Fixes #2488

Using the testing/content/files as the CONTENT_ROOT:

Screen Shot 2021-01-12 at 5 23 34 PM

@peterbe peterbe mentioned this pull request Jan 12, 2021
Merged
@peterbe peterbe marked this pull request as draft January 12, 2021 22:42
@peterbe
Copy link
Contributor Author

peterbe commented Jan 12, 2021

I'm going to check by doing one more complete build.

@peterbe peterbe mentioned this pull request Jan 12, 2021
Closed
@peterbe peterbe marked this pull request as ready for review January 12, 2021 22:53
escattone
escattone approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterbe I tested this thoroughly independently, also running a full build of the English docs to look for issues. This looks and works great, thank you!

@escattone escattone merged commit 8f176e6 into mdn:master Jan 13, 2021
@peterbe peterbe deleted the 2488-embedlivesample-fails-if-the-id-gets-changed-from-the-text branch January 13, 2021 16:02
@caugner caugner mentioned this pull request Sep 12, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escattone escattone escattone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EmbedLiveSample fails if the ID gets changed from the text
2 participants
@peterbe @escattone