enhance(layout): add margin for "(en-US)" indicator #12204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
requested changes
Nov 28, 2024
caugner
changed the title
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds margin for "(en-US)" indicator to improve visual perception.
Also the
.only-in-en-us spanCSS class was removed because it is no longer used (as far as I understand).Relates: #11052
Problem
Now "(en-US)" indicator "sticks" to link text. This applies to all locales except
zh-CNandzh-TW(because in Chinese the bracket symbol already includes an extra space and it looks harmonious).Solution
This PR adds
margin-left: 0.5ch;to "(en-US)" indicator inde,es,fr,ja,ko,ruandpt-BRlocale.Alternative method: add an indent to the main
html a.only-in-en-us:afterclass and make exceptions forzh-CNandzh-TW.Screenshots
esfrjakorupt-BR