feature(translated-content): add github contributor profile list UI #11755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yin1999
reviewed
Sep 9, 2024
| const contributorJSONUrl = `https://api.github.com/repos/mdn/translated-content/commits?path=files/${url}/index.md`; | ||
|
|
||
| const { error, data = [] } = useSWR<any>(contributorJSONUrl, async (url) => { | ||
| const response = await fetch(url); |
There was a problem hiding this comment.
I think we should provide GitHub Token when available: https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#example-2-calling-the-rest-api
There was a problem hiding this comment.
Thank you for comment.
The current structure is one that is called on every page. There are limitations in calling the GitHub API, so caching(server..?) or other ways seem to be necessary.
For this reason I have created a discussion below regarding this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the feature to enhance visual elements for page contributors.
Problem
I was thinking about an alternative to the page provided as txt.
https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/Array/of/contributors.txt
Solution
I suggest showing the profile at least after yari(github). However, there is a problem with my PR. I'm requesting the github API, but there are limitations.
Screenshots
Before
After
Related Discussion