Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pong): avoid duplicate "https:" #11212

Merged
merged 1 commit into from
May 30, 2024
Merged

fix(pong): avoid duplicate "https:" #11212

merged 1 commit into from
May 30, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 30, 2024 •
edited
Loading

Summary

(MP-1160)

Problem

Ads were no longer clickable, because upstream started including https: in URLs which we had been manually adding so far.

Solution

Stop adding https: if the URL already contains it.

How did you test this change?

Deployed manually to stage.

@caugner caugner requested a review from a team as a code owner May 30, 2024 03:03
caugner
caugner commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval to resolve an ongoing incident.

@caugner caugner merged commit c4ef726 into main May 30, 2024
12 checks passed
@caugner caugner deleted the MP-1160-avoid-duplicate-https branch May 30, 2024 03:17
@github-actions github-actions bot mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
placement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@caugner