Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(flaws-page): specify 'yarn build' usage in error message for clarity #10785

Merged
merged 1 commit into from
Mar 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions client/src/flaws/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ function DocumentsTable({
)}
</h3>
{!counts.built ? (
<WarnAboutNothingBuilt />
<WarnAboutNothingBuilt locale={locale} />
) : (
<h4 className="subheader">
{counts.built.toLocaleString()} documents built ({locale})
Expand Down Expand Up @@ -735,13 +735,13 @@ function PageLink({
);
}

function WarnAboutNothingBuilt() {
function WarnAboutNothingBuilt({ locale }) {
return (
<div className="notecard warning document-warnings">
<h4>No documents have been built, so no flaws can be found</h4>
<p>
At the moment, you have to use the command line tools to build documents
that we can analyze.
Run <code>yarn build --locale {locale.toLowerCase()}</code> to build all
documents for the current locale.
</p>
</div>
);
Expand Down