fix(playground): remove redundant vertical scroll bar #10752
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seeing two y-scrollbars in editors when code is long.
The playground doesn't work in internet archive so it's hard to know when and where the issue appeared. Looking at the current code. Parent wrapper
.editor
hasoverflow: scroll
set so both x and y scrollbars are always visible. And child wrapper.cm-editor
also has height100%
set. As the child has fixed height so when code is long the child also get y-scrollbar.Solution
Instead of limiting the child
.cm-editor
height to100%
setmin-height: 100%
. So the child becomes long and the parent's.editor
's scrollbar becomes usable.Bonus
The code is actually being wrapped so there is no need of x-scrollbar on
.editor
. So instead ofoverflow: scroll
we could useoverflow-y: scroll
.Screenshot
Before
After
Testing
Ran
yarn dev
and tried on Chrome, Edge, and Brave browsers on Linux Mint.