-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(macros/secureContext_inline): replace notecard with badge #10214
Conversation
Co-authored-by: Onkar Ruikar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the discussion in the description of this PR (https://github.com/mdn/content/discussions/30546) is 404.
I think this PR is basically point 1 of https://github.com/orgs/mdn/discussions/482#discussioncomment-7825014.
It is. My error. (Don't know where the error comes from) |
Thank you! |
Summary
{{securecontext_inline}}
uses an ugly notecard class. As we decided to continue using it in the foreseeable future, in https://github.com/orgs/mdn/discussions/482#discussioncomment-7825014., we need to get it more standard.Problem
The
notecard
class is not suitable for a badge.Solution
Switch to use the already existing
badge
class.Screenshots
Before
After
How did you test this change?
Locally (and I needed it for the screenshots)