Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/secureContext_inline): replace notecard with badge #10214

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented Dec 21, 2023

Summary

{{securecontext_inline}} uses an ugly notecard class. As we decided to continue using it in the foreseeable future, in https://github.com/orgs/mdn/discussions/482#discussioncomment-7825014., we need to get it more standard.

Problem

The notecard class is not suitable for a badge.

Solution

Switch to use the already existing badgeclass.

Screenshots

Before

Capture d’écran 2023-12-21 à 09 49 23

After

Capture d’écran 2023-12-21 à 09 51 06


How did you test this change?

Locally (and I needed it for the screenshots)

@teoli2003 teoli2003 requested a review from a team as a code owner December 21, 2023 08:57
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Dec 21, 2023
@hamishwillee
Copy link
Contributor

@caugner @wbamberg Any chance you guys could look at this?

@teoli2003
Copy link
Contributor Author

@caugner @wbamberg Any chance you guys could look at this?

FYI, Yari is in a deployment freeze until Jan 3rd, 2024, so, while reviewing this PR is welcome, it won't make it to production before that date.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the discussion in the description of this PR (https://github.com/mdn/content/discussions/30546) is 404.

I think this PR is basically point 1 of https://github.com/orgs/mdn/discussions/482#discussioncomment-7825014.

@teoli2003
Copy link
Contributor Author

The link to the discussion in the description of this PR (https://github.com/mdn/content/discussions/30546) is 404.

I think this PR is basically point 1 of https://github.com/orgs/mdn/discussions/482#discussioncomment-7825014.

It is. My error. (Don't know where the error comes from)

@caugner caugner changed the title Use badge for {{secureContext_inline}} fix(macros/secureContext_inline): use badge Jan 25, 2024
@caugner caugner changed the title fix(macros/secureContext_inline): use badge chore(macros/secureContext_inline): replace notecard with badge Jan 26, 2024
@caugner caugner merged commit 285b449 into mdn:main Jan 26, 2024
10 checks passed
@teoli2003
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants