-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content bug: <browser compatibility link invalid in Non-English page> #3882
Comments
@escattone @peterbe This should probably move to yari (but I don't have the magic power). Essentially the translated string for this (and other) macros uses the same hard coded anchor The "easy" fix would be to translate the anchor too, but then of course we have to let the translators know what the standard name for this section should be. Maybe a better approach would be to include the anchor |
The problem is that https://github.com/mdn/translated-content/blob/50513730f1bfcc9ec23f19600f756606c2498d52/files/zh-cn/web/api/resizeobserver/index.html#L66 should be changed to: <h2 id="browser_compatibility">浏览器兼容性</h2> but I'm a bit surprised why it didn't do that automatically at build-time. |
Now I understand why it doesn't "force" it to become I was wrong in saying that it should be changed to: <h2 id="browser_compatibility">浏览器兼容性</h2> It can remain as: <h2 id="浏览器兼容性">浏览器兼容性</h2> But we'll need to change the |
I think we should translate SeeCompatTable.ejs and keep existing page id corresponding to language. |
What page(s) did you find the problem on?
It is a widespread problem over many pages.
There is an example:
https://developer.mozilla.org/zh-CN/docs/Web/API/ResizeObserver#browser_compatibility
Specific page section or heading?
The experimental label, #browser_compatibility link.
What is the problem?
The experimental label, #browser_compatibility archor link cannot be positioned correctly.
I think it’s because of the incorrect ID translated.
What did you expect to see?
There is a correct example:
https://developer.mozilla.org/ja/docs/Web/API/WritableStream#browser_compatibility
Did you test this? If so, how?
Manual test.
The text was updated successfully, but these errors were encountered: