fix(l10n): improve style of en-US links #11052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to identify the pages available in current locale.
leon-win
reviewed
May 15, 2024
Comment on lines
+948
to
+949
| display: inline-block; | ||
| font-size: var(--type-tiny-font-size); |
There was a problem hiding this comment.
Suggested change
| display: inline-block; | |
| font-size: var(--type-tiny-font-size); | |
| display: inline-block; | |
| margin-left: 0.25rem; | |
| font-size: var(--type-tiny-font-size); |
I also suggest adding a little margin before the indicator to improve perception:
Before
After
This will be even more noticeable in the sidebar:
Before
After
There was a problem hiding this comment.
Just now I noticed that I wrote a comment, but forgot to send a review 🤦))
Please take a look. If you agree with such changes, then I can open a new PR.
There was a problem hiding this comment.
@leon-win Sorry, I didn't see your comment. Would you like to open a PR for this? Maybe 0.5ch would be better than 0.25rem though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-1101)
Problem
The en-US link indicators (e.g. "(angl.)") are very prominent and underlined, and they sometimes break over one line.
Solution
Reduce the font-size, stop underlining the indicator, and avoid the line break.
Screenshots
Note: The column-breaks in the index layout will be fixed in #11053.
How did you test this change?
Ran
yarn devlocally and checked the Web/API page in fr and zh-CN.