Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using <hr> tag as a border inside of ul #10777

Closed
3 tasks done
PolyDevil opened this issue Mar 24, 2024 · 1 comment · Fixed by #10786
Closed
3 tasks done

Using <hr> tag as a border inside of ul #10777

PolyDevil opened this issue Mar 24, 2024 · 1 comment · Fixed by #10786
Assignees
Labels
curriculum p2 We want to address this but may have other higher priority items.

Comments

@PolyDevil
Copy link

Summary

image

It is stated that the permitted content of ul tag is:

Zero or more li, script and template elements.

It is also stated that hr is a thematic break;
So having it as a first child doesnt make any sense.

URL

https://developer.mozilla.org/en-US/curriculum/

Reproduction steps

  1. Open a page
  2. Look at the source code

Expected behavior

Expected to have a valid html

Actual behavior

HTML code on curriculum page doesnt make any sense.

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Android

Screenshot

No response

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 24, 2024
@caugner
Copy link
Contributor

caugner commented Mar 25, 2024

@fiji-flo Should we wrap the <hr> like this: <li style="display: contents"><hr></li>?

Context:

@caugner caugner added p2 We want to address this but may have other higher priority items. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Mar 25, 2024
fiji-flo added a commit that referenced this issue Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
curriculum p2 We want to address this but may have other higher priority items.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants