fix(macros/CSS_Ref): fix special cases #10241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
changed the title
fiji-flo
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
{{CSS_Ref}}creates an index of CSS features at https://developer.mozilla.org/en-US/docs/Web/CSS/Reference. It takes data from mdn/data and has some hardcoded "exceptions".Over the years, this list got outdated: some new exceptions are missing, and some old ones need to be updated.
Problem
Links generated by CSS_Ref are sometimes incorrect. This PR fixes those that can be fixed. Note that mdn/data#697 removed abandoned values.
Solution
Updated the exception list.
Screenshots
No change in UI
Before:
After
Note: more message will be removed once mdn/data#697 is in prod. (the remaining ones are missing pages)
How did you test this change?
Locally, clicking on the links I changed to test them.
Note: One day, we will sever the connection to mdn/data (and likely use
page-type:to select an entry if we keep the macro at all.