Remove abandoned value + fix renamed ones #697
Conversation
teoli2003
changed the title
There was a problem hiding this comment.
Thanks for these updates, @teoli2003. All changes look good. I only have one comment in the updating_css_json.md file about the animation syntax. LMK what you think.
docs/updating_css_json.md
Outdated
| @@ -318,7 +318,7 @@ For shorthand properties, several entries are a list of the longhand properties | |||
| ```json | |||
| { | |||
| "animation": { | |||
| "syntax": "<single-animation-name> || <time> || <timing-function> || <time> || <single-animation-iteration-count> || <single-animation-direction> || <single-animation-fill-mode> || <single-animation-play-state>", | |||
| "syntax": "<single-animation-name> || <time> || <easing-function> || <time> || <single-animation-iteration-count> || <single-animation-direction> || <single-animation-fill-mode> || <single-animation-play-state>", | |||
There was a problem hiding this comment.
What do you think about updating this syntax to:
| "syntax": "<single-animation-name> || <time> || <easing-function> || <time> || <single-animation-iteration-count> || <single-animation-direction> || <single-animation-fill-mode> || <single-animation-play-state>", | |
| "syntax": "<single-animation>#", |
I realize that you were only updating the timing-function to the more current easing-function and I was doing a casual comparison with the syntax on the animation page when I noticed this.
The Formal syntax section and the spec list the syntax as:
animation = <single-animation>#
The value for the "syntax" key above on L321 is an enumeration of <single-animation> values. The syntaxes.json file does have an entry for single-animation. Perhaps that's the one that needs to be updated, for example, to remove <'animation-duration'> and add <time> among other things?
Also to note, in the "syntax" key on L321, <time> appears twice.
In this particular instance, animation was only used as an example to show how shorthand properties are treated but looks like the property syntax changed over time 🙂.
There was a problem hiding this comment.
I switched to use border as an example of a shorthand property, as it still has the classical structure of shorthands (animation or background allow for several animations or background and use the # syntax).
There was a problem hiding this comment.
This is a much better example. Thanks!
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Several features have been renamed or abandoned over the years.
Because they are listed incorrectly here, they lead to broken links in CSS/Reference.
This PR removed them and renamed
<timing-function>into the<easing-function>as used everywhere.