Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated mediawiki.external macro from es #9634

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Remove deprecated mediawiki.external macro from es #9634

merged 2 commits into from
Nov 1, 2022

Conversation

Graywolf9
Copy link
Contributor

Description

Remove deprecated spec macro from es

Process: remove the macro and replace with the rendered content

Motivation

The chore of deprecated macros removal

Additional details

Related issues and pull requests

Relates to https://github.com/orgs/mdn/discussions/263

@Graywolf9 Graywolf9 added the l10n-es Issues related to Spanish content. label Nov 1, 2022
@Graywolf9 Graywolf9 requested a review from a team as a code owner November 1, 2022 18:38
@Graywolf9 Graywolf9 requested review from marcelozarate and removed request for a team November 1, 2022 18:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022 •
edited
Loading

Preview URLs (16 pages)
Flaws (61)

URL: /es/docs/Web/API/Document_Object_Model/Traversing_an_HTML_table_with_JavaScript_and_DOM_Interfaces
Title: Trazado de una tabla HTML mediante JavaScript y la Interface DOM
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (0 in common of 5 possible)

URL: /es/docs/Web/API/Document_Object_Model/Introduction
Title: Introducción
Flaw count: 4

  • broken_links:
    • Is currently http:// but can become https://
    • Link points to the page it's already on
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (0 in common of 4 possible)

URL: /es/docs/Web/API/Window/error_event
Title: GlobalEventHandlers.onerror
Flaw count: 3

  • macros:
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
  • translation_differences:
    • Differences in the important macros (0 in common of 5 possible)

URL: /es/docs/Web/API/HTMLStyleElement
Title: HTMLStyleElement
Flaw count: 12

  • broken_links:
    • Can't resolve /Es/DOM/Element.style
    • Can't resolve /Es/DOM/Stylesheet
    • Can't resolve /Es/DOM/CssRule
    • Can't resolve /Es/DOM/CSS
    • Can't resolve /Es/DOM/CSS
    • and 6 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /es/docs/Web/API/Document/styleSheets
Title: Document.styleSheets
Flaw count: 3

  • broken_links:
    • Can't resolve /es/DOM/stylesheet
    • Can't resolve /es/DOM/stylesheet
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /es/docs/Web/HTML/Element/meta
Title: meta
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (0 in common of 3 possible)

URL: /es/docs/Web/HTML/Element/col
Title: col
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (0 in common of 4 possible)

URL: /es/docs/Web/JavaScript/Reference/Global_Objects/Number/toString
Title: Number.prototype.toString()
Flaw count: 2

  • macros:
    • /es/docs/Web/JavaScript/Reference/Global_Objects/Number/toExponential does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toExponential
  • translation_differences:
    • Differences in the important macros (0 in common of 3 possible)

URL: /es/docs/Web/JavaScript/Reference/Global_Objects/Object/toString
Title: Object.prototype.toString()
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • translation_differences:
    • Differences in the important macros (0 in common of 3 possible)

URL: /es/docs/Web/JavaScript/Reference/Global_Objects/String/match
Title: String.prototype.match()
Flaw count: 2

  • broken_links:
    • Can't resolve /es/docs/Web/JavaScript/Referencia/Objetos_globales/RegExp
  • translation_differences:
    • Differences in the important macros (0 in common of 3 possible)

URL: /es/docs/Web/JavaScript/Reference/Operators/Property_Accessors
Title: Miembros
Flaw count: 4

  • macros:
    • /es/docs/Web/JavaScript/Reference/eval does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/eval
  • broken_links:
    • Can't resolve /es/docs/Mozilla/SpiderMonkey
    • Can't resolve /es/docs/Web/JavaScript/Referencia/Operadores/this#Funciones_enlazadas
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)

URL: /es/docs/Web/JavaScript/Reference/About
Title: Acerca de
Flaw count: 9

  • broken_links:
    • Can't resolve /es/Guía_JavaScript_1.5/Sentencias_de_manejo_de_excepciones
    • Can't resolve /es/Guía_JavaScript_1.5/Escribir_un_patrón_de_expresión_regular#Uso_de_caracteres_especiales
    • Can't resolve /es/Guía_JavaScript_1.5/Escribir_un_patrón_de_expresión_regular#Uso_de_caracteres_especiales
    • Can't resolve /es/Guía_JavaScript_1.5/Escribir_un_patrón_de_expresión_regular#Uso_de_caracteres_especiales
    • Can't resolve /es/HTML
    • and 4 more flaws omitted

URL: /es/docs/Web/CSS/list-style
Title: list-style
Flaw count: 6

  • macros:
    • /es/docs/Web/CSS/Media:Visual does not exist
    • /es/docs/Web/CSS/computed%20value does not exist
  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 7 possible)

URL: /es/docs/Web/CSS/content
Title: content
Flaw count: 4

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (0 in common of 10 possible)

URL: /es/docs/Web/CSS/font-variant
Title: font-variant
Flaw count: 3

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 6 possible)

URL: /es/docs/Web/CSS/cursor
Title: cursor
Flaw count: 4

  • broken_links:
    • Can't resolve /samples/cssref/cursor.html
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
  • translation_differences:
    • Differences in the important macros (1 in common of 5 possible)

(this comment was updated 2022-11-01 18:54:49.914161)

JuanVqz
JuanVqz approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por contribuir, esto se ve muy bien :)

@JuanVqz JuanVqz merged commit 90f38b1 into mdn:main Nov 1, 2022
@elo1lson elo1lson mentioned this pull request Nov 3, 2022
Merged
@Graywolf9 Graywolf9 deleted the es-remove-mediawiki.external-macro branch July 5, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanVqz JuanVqz JuanVqz approved these changes

@marcelozarate marcelozarate Awaiting requested review from marcelozarate marcelozarate is a code owner automatically assigned from mdn/yari-content-es

Assignees
No one assigned
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Graywolf9 @JuanVqz